Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relative paths in html #772

Merged
merged 5 commits into from
Dec 28, 2022
Merged

Relative paths in html #772

merged 5 commits into from
Dec 28, 2022

Conversation

nojaf
Copy link
Collaborator

@nojaf nojaf commented Sep 29, 2022

Fixes #769

@dsyme
Copy link
Contributor

dsyme commented Oct 11, 2022

Hmm failing tests:

  Failed Substitutions apply to correct parts of inputs [54 ms]
  Error Message:
   System.Exception : "substitute-in-fsx-code: simple1" is not a substring of "<!DOCTYPE html>

@nojaf
Copy link
Collaborator Author

nojaf commented Oct 11, 2022

@dsyme found the problem!

@nojaf
Copy link
Collaborator Author

nojaf commented Dec 28, 2022

Well hello, fellow maintainers, @baronfel and @nhirschey, is this one ok for you folks?

baronfel
baronfel approved these changes Dec 28, 2022
View reviewed changes
Copy link
Collaborator

@baronfel baronfel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@baronfel baronfel merged commit d0c2d48 into fsprojects:main Dec 28, 2022
@nojaf nojaf deleted the relative-paths-in-html branch December 28, 2022 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baronfel baronfel baronfel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Relative paths in html anchors
3 participants
@nojaf @dsyme @baronfel